awslabs / service-workbench-on-aws

A platform that provides researchers with one-click access to collaborative workspace environments operating across teams, universities, and datasets while enabling university IT stakeholders to manage, monitor, and control spending, apply security best practices, and comply with corporate governance.
Apache License 2.0
177 stars 119 forks source link

[Bug] ERROR ValidationException: Rate exceeded” when you hit the Workspace Types page if you have lots of versions of a product in Service Catalog #937

Open jianjun66 opened 2 years ago

jianjun66 commented 2 years ago

Describe the bug When you create lots of new versions of a product in Service Catalog ( in my case, 12 versions of SageMaker Notebook), AWS backend API will error out with “ERROR ValidationException: Rate exceeded” when you hit the Workspace Types page. - this is due to serviceCatalogClient.listProvisioningArtifacts({ ProductId: product.ProductId }).promise(), gets called too many times in a short burst. I think this is a bug that needs to be fixed

To Reproduce Steps to reproduce the behavior:

  1. cretate 10 versions of a workspace type ,
  2. Go to 'workspaces types'
  3. See error

Expected behavior Should see the list of Service Catalog items

Screenshots If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):

Additional context Add any other context about the problem here.

Bingjiling commented 2 years ago

Hi @jianjun66 ,

Thanks for reaching out! We'll take a look into this issue.

Thanks, Yanyu

Bingjiling commented 2 years ago

Hi @jianjun66,

We're working on pagination to address scaling issues in SWB, and a ticket has been created in the backlog for this specific issue.

Thanks, Yanyu