awslabs / shuttle

Shuttle is a library for testing concurrent Rust code
Apache License 2.0
670 stars 34 forks source link

[Suggestion] for PR #121 Add `as_any` to Tag trait #124

Closed sarsko closed 1 year ago

sarsko commented 1 year ago

This is a suggestion for an addition to https://github.com/awslabs/shuttle/pull/121.

I feel like either I don't know how to use GitHub or this is a feature GitHub should add. I found a way to do single-region suggestions, but no way to say "hey, here is a proposed change you may want, feel free to accept or reject it".

Anyhow, this is a suggested addition of a marker trait Taggable in order to undo the "(almost) everything is now Tag" caused by the blanket implementation of Tag for types which are Debug + Any.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.