awslabs / soci-snapshotter

A containerd snapshotter plugin which enables standard OCI images to be lazily loaded without requiring a build-time conversion step.
Apache License 2.0
534 stars 55 forks source link

[Bug] Integration tests fail with differing GLIBC versions #734

Open turan18 opened 1 year ago

turan18 commented 1 year ago

Description

The current version of the Go base image that we use for our integration tests contains v2.28 of glibc. When building our integration test image we copy over the binaries built on the host to the image. If the glibc version used on the host to build our binaries is > 2.28, our integration tests may break because of incompatible glibc versions.

Steps to reproduce the bug

No response

Describe the results you expected

Integration tests should not break because of incompatible glibc versions and should be consistent across different operating systems.

We should either completely switch to building static binaries by default or (preferred) have the integration target build static binaries only.

Host information

  1. OS:
  2. Snapshotter Version:
  3. Containerd Version:

Any additional context or information about the bug

No response

Kern-- commented 1 year ago

I think this needs some thought on the tradeoffs between statically linking the snapshotter outside of the test container vs dynamically linking inside the test container.