search

awslabs / ssosync

Populate AWS SSO directly with your G Suite users and groups using either a CLI or AWS Lambda
Apache License 2.0
525 stars 181 forks source link

Add users without groups #101

Closed sidekick-eimantas closed 7 months ago

sidekick-eimantas commented 2 years ago

Users that do not belong to any groups should be synced in as well. Right now they're ignored.

ChrisPates commented 1 year ago

Apologies this feature was never implemented. Working on it now in a feature branch. It will also support multiple queries (implementing that feature for groups, in the same sprint).

omer2500 commented 1 year ago

@ChrisPates Any eta on those features?

ChrisPates commented 1 year ago

I'm working on it in a branch currently. You'll have the ability to perform group/user matching (multiple queries), include group/user, ignore group/user and finally flatten nested groups into the top level group.

Indransh commented 1 year ago

@ChrisPates How can one track the progress for this feature? There are related PRs that were closed in favor of feature-EnhancedMatch, but the last commit on that branch is 2+ months old.

Is this feature still on the roadmap? If you have a list of open issues for your feature branch, maybe we could help by contributing?

sidekick-eimantas commented 1 year ago

@ChrisPates How can one track the progress for this feature? There are related PRs that were closed in favor of feature-EnhancedMatch, but the last commit on that branch is 2+ months old.

Is this feature still on the roadmap? If you have a list of open issues for your feature branch, maybe we could help by contributing?

Second. We have a go dev in house that could help out if needed

ChrisPates commented 1 year ago

Apologies, I’ve had to prioritise other projects for a couple of months. Thank you for the offers of assistance they are much appreciated. I’m planning on getting back into this branch in about 10 days, once I have dealt with some of the items I was part way through, I’ll be in touch. 

At the moment I’ve been focused on some fairly heavy read storing so the modules make much logical sense.

Once that is done and all the test have been reworked to match, it should be much easier to contribute features.

Kind regards,

Chris

On 23 Apr 2023, at 18:38, sidekick-eimantas @.***> wrote:



@ChrisPates How can one track the progress for this feature? There are related PRs that were closed in favor of feature-EnhancedMatch https://github.com/awslabs/ssosync/tree/feature-EnhancedMatch , but the last commit on that branch is 2+ months old.

Is this feature still on the roadmap? If you have a list of open issues for your feature branch, maybe we could help by contributing?

Second. We have a go dev in house that could help out if needed

— Reply to this email directly, view it on GitHub https://github.com/awslabs/ssosync/issues/101#issuecomment-1519118072 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVULYPKYIFO7JDVFS7HWATXCVSJ5ANCNFSM6AAAAAAQVDAT7E . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ABVULYLMR6ZIJNT7TZNLXQ3XCVSJ5A5CNFSM6AAAAAAQVDAT7GWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS2RPTPQ.gif Message ID: @.***>

et304383 commented 1 year ago

This is a critically missing feature. As I just discovered that you delete any groups that you did not sync from GW. That is terrible. If I wanted to delete groups that do not line up with GW, I would do it myself. Shame on you for such destructive default behaviour.