Closed cmbrehm closed 1 year ago
+1 We've experienced the same behaviour and can confirm that this code change works as expected.
@ChrisPates FYI
Looks good, I'll merge into a bug fix branch next week, test and hopefully release it before the end of the week as v2.0.3.
Will release as v2.0.3 once testing completed.
Issue #, if available: #52, #53, referenced in #91
Description of changes: I have specified what I believe to be the intentions of interactions between
group-match
,ignore-groups
andinclude-groups
in the documentation and unit test cases. I also manually tested the different combinations and they worked as I would have expected. We would have to (should?) do some further refactoring to build comprehensive unit test cases for how the config options map to behavior.Expected Behavior: Above should now synchronize all groups that match.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.