search

awslabs / ssosync

Populate AWS SSO directly with your G Suite users and groups using either a CLI or AWS Lambda
Apache License 2.0
525 stars 181 forks source link

getGroupUsersOperations should return the delete and equals arrays - but does not #106

Closed tpeace closed 1 year ago

tpeace commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. this code expects a return value from getGroupUsersOperations: https://github.com/awslabs/ssosync/blob/f57081807907ab16aed2703e5191db8fb35a3d78/internal/sync.go#L405
  2. but there clearly isn't one: https://github.com/awslabs/ssosync/blob/f57081807907ab16aed2703e5191db8fb35a3d78/internal/sync.go#L661

Expected behavior The function getGroupUsersOperations should return the delete and equals arrays - but it does not.

Additional context internal/sync.go line 661 should read return delete, equals

Thanks!

tpeace commented 1 year ago

Never mind. It works either way.