ChrisPates
commented
1 year ago Sadly this is a feature of cloudformation parameters if a pattern is supplied to validate the parameter supplied the parameter can never be left empty.
I have a branch I’m working on to address this and other frustration behaviours.
Kind regards,
Chris
On 4 May 2023, at 13:32, Yair Halevi (Spock) @.***> wrote:
Describe the bug When deploying the application from the AWS Serverless Application Repository, none of the fields can be left empty. The deployment fails with a warning similar to the attached.
This is problematic because:
- It effectively forces users to use an explicit include list for groups.
- It requires values for GoogleGroupMatch, GoogleUserMatch, IgnoreGroups and IgnoreUsers. While one can provide a wildcard filter for the former two (email:*) and a dummy value for the latter two, it is still a nuissance.
To Reproduce Steps to reproduce the behavior:
- Go to 'https://console.aws.amazon.com/lambda/home#/create/app?applicationId=arn:aws:serverlessrepo:us-east-2:004480582608:applications/SSOSync https://console.aws.amazon.com/lambda/home#/create/app?applicationId=arn:aws:serverlessrepo:us-east-2:004480582608:applications/SSOSync '
- Fill in all the arguments except IncludeGroups, and deploy
- See error
Expected behavior It would be better if optional parameters can just be left empty and achieve behavior similar to omitting the parameter in the CLI.
— Reply to this email directly, view it on GitHub https://github.com/awslabs/ssosync/issues/132 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVULYOG5646RNDTRU7RMU3XEOHWTANCNFSM6AAAAAAXVU7BZE . You are receiving this because you are subscribed to this thread. https://github.com/notifications/beacon/ABVULYIJ2576DLHZAWENRQLXEOHWTA5CNFSM6AAAAAAXVU7BZGWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHGKFCQWU.gif Message ID: @.***>
TomD3Wiz
Describe the bug When deploying the application from the AWS Serverless Application Repository, none of the fields can be left empty. The deployment fails with a warning similar to the attached.
This is problematic because:
GoogleGroupMatch,GoogleUserMatch,IgnoreGroupsandIgnoreUsers. While one can provide a wildcard filter for the former two (email:*) and a dummy value for the latter two, it is still a nuissance.To Reproduce Steps to reproduce the behavior:
IncludeGroups, and deployExpected behavior It would be better if optional parameters can just be left empty and achieve behavior similar to omitting the parameter in the CLI.