awslabs / ssosync

Populate AWS SSO directly with your G Suite users and groups using either a CLI or AWS Lambda
Apache License 2.0
512 stars 175 forks source link

Serverless Application Repository not updated to 2.x.x #169

Closed pecigonzalo closed 5 months ago

pecigonzalo commented 6 months ago

Describe the bug The SSOSync SAR has not been updated to any newer version than 1.x.rc. Is SAR no longer supported?

Expected behavior The SAR shows up to date versions of SSOSync

ChrisPates commented 6 months ago

The official SAR repo is up to date (see link in the readme). However, non-official SAR apps do exist. 

Which sat arm are you looking at?

Kind regards,

Chris 

On 7 Feb 2024, at 13:35, Gonzalo Peci @.***> wrote:



Describe the bug The SSOSync SAR has not been updated to any newer version than 1.x.rc. Is SAR no longer supported?

Expected behavior The SAR https://eu-west-1.console.aws.amazon.com/lambda/home#/create/app?applicationId=arn:aws:serverlessrepo:us-east-2:004480582608:applications/SSOSync shows up to date versions of SSOSync

— Reply to this email directly, view it on GitHub https://github.com/awslabs/ssosync/issues/169 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVULYIPG564Q6NDFP5IEC3YSN7INAVCNFSM6AAAAABC526OH2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGEZDGMBVGQZDOMA . You are receiving this because you are subscribed to this thread. https://github.com/notifications/beacon/ABVULYOQDVDWHY2ZPGI622DYSN7INA5CNFSM6AAAAABC526OH2WGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHH5CZ4XY.gif Message ID: @.***>

pecigonzalo commented 6 months ago

In using the one linked in the issue, the official one linked from the reader. The description says its version 1.x.

Maybe the description is outdated?

On Wed, Feb 7, 2024 at 14:57 Chris Pates @.***> wrote:

The official SAR repo is up to date (see link in the readme). However, non-official SAR apps do exist.

Which sat arm are you looking at?

Kind regards,

Chris

On 7 Feb 2024, at 13:35, Gonzalo Peci @.***> wrote:



Describe the bug The SSOSync SAR has not been updated to any newer version than 1.x.rc. Is SAR no longer supported?

Expected behavior The SAR < https://eu-west-1.console.aws.amazon.com/lambda/home#/create/app?applicationId=arn:aws:serverlessrepo:us-east-2:004480582608:applications/SSOSync> shows up to date versions of SSOSync

— Reply to this email directly, view it on GitHub < https://github.com/awslabs/ssosync/issues/169> , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABVULYIPG564Q6NDFP5IEC3YSN7INAVCNFSM6AAAAABC526OH2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGEZDGMBVGQZDOMA> . You are receiving this because you are subscribed to this thread. < https://github.com/notifications/beacon/ABVULYOQDVDWHY2ZPGI622DYSN7INA5CNFSM6AAAAABC526OH2WGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHH5CZ4XY.gif> Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/awslabs/ssosync/issues/169#issuecomment-1932105684, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACLS7CPNU63U2XLBPXMSDHDYSOB4FAVCNFSM6AAAAABC526OH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZSGEYDKNRYGQ . You are receiving this because you authored the thread.Message ID: @.***>

ChrisPates commented 6 months ago

So the header reads:

SSOSync — version 2.1.2

granted it looks like the Source code URL is stuck pointing to an older version.

I'll take a look at getting that updated in the next release. Was there anywhere else you saw erroneous references?

pecigonzalo commented 6 months ago

I thought from the source ref that this was referring to 1.x. If that is not the case, then seems like a minor details. It did confuse me :D but for sorry for the noise.