search

awslabs / ssosync

Populate AWS SSO directly with your G Suite users and groups using either a CLI or AWS Lambda
Apache License 2.0
512 stars 175 forks source link

IgnoreGroups and potentially other regexes have invalid checks #171

Closed pecigonzalo closed 5 months ago

pecigonzalo commented 6 months ago

Describe the bug

The validation RegEx by IgnoreGroups does not accept this@that.com,foo@bar.com and instead fails due to not matching regex (?!.*\\s)|([0-9a-zA-Z\\-= _]*)(,[0-9a-zA-Z\\-=@. _]*)*. If you inspect the regex in https://regex101.com/ or similar you can see that this does not accept this@that.com,foo@bar.com as it requires , in the same group as the @. As a workaround you can place a , at the start of the string.

To Reproduce Steps to reproduce the behavior:

  1. Try to provision the SAR app
  2. Set foo@bar.com,this@that.com as the IgnoreGroups parameter
  3. See error

Expected behavior

IgnoreGroups does not require starting with a ,