awslabs / ssosync

Populate AWS SSO directly with your G Suite users and groups using either a CLI or AWS Lambda

Apache License 2.0

528 stars 182 forks source link

Fix token length which now appears to be above 600 #212

Closed xelfer closed 2 months ago

xelfer commented 3 months ago

Issue #, if available:

211

Description of changes:

Adjust SCIMEndpointAccessToken regex to allow more than 600 characters (raised to 620) as a freshly generated token by the AWS console is 603 characters.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ChrisPates commented 2 months ago

Change looks good, merging and running through test pipelines.

xelfer commented 2 months ago

@ChrisPates thanks! seems to be hitting a go version error?

ChrisPates commented 2 months ago

Yeah, somethings got broken in the workflow.

I'll probably have to do work on the CICD pipeline as well.

I'm fixing that in the latest release and then I'll attempt to merge the PR again.

It appears to be related to go.lang 1.20.x -> 1.23.x change.

xelfer commented 2 months ago

No problem, do you have an ETA at all? If it's longer than a few days I'll just deploy it outside of SAM for myself. Thanks!

ChrisPates commented 2 months ago

Hopefully today/tomorrow,

I wouldn't bothered with SAM, I would use the official builds in SAR. A lot less hassle.

Chris

xelfer commented 2 months ago

awesome, thank you!

ChrisPates commented 2 months ago

Okay, the workflows are working, can you update your fork and PR from master, and we can see whether we can merge.