search

awslabs / ssosync

Populate AWS SSO directly with your G Suite users and groups using either a CLI or AWS Lambda
Apache License 2.0
530 stars 182 forks source link

Fix nested Google groups causing panic, fix adding users to groups immediately after creating AWS group #74

Closed orishoshan closed 1 year ago

orishoshan commented 2 years ago

Issue #, if available:

Description of changes:

  1. Populate group ID after creation in addAWSGroups - group ID would not be populated, making the PATCH request for adding users to the AWS group fail.
  2. Skip non-users when adding users to groups (skip nested groups) - would fail and stop prematurely previously, when attempting to GetUsers from Google for the nested group.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

danleyden commented 1 year ago

95 may be a better solution for (2) - drill down into the nested group rather than simply ignore

ChrisPates commented 1 year ago

Issue resolved in v2.0.2