fix: A case where the user already exists but it tries to create again

awslabs / ssosync

Populate AWS SSO directly with your G Suite users and groups using either a CLI or AWS Lambda

Apache License 2.0

530 stars 182 forks source link

fix: A case where the user already exists but it tries to create again #77

Closed bkmeneguello closed 1 year ago

bkmeneguello commented 2 years ago

Since AWS SSO SCIM only supports fetching up to 50 users in the ListUsers request, we must ignore the case when the API returns the HTTP Code 409 (Conflict), that indicated the resource already exists.

Fixes #65

JubbaSmail commented 2 years ago

can someone approve this PR? I tested it and it's working as expected

lucas-caylent commented 2 years ago

Can we push this forward, it's blocking us

AlKapkone commented 2 years ago

Any updates ?

AlKapkone commented 2 years ago

Hi, @bkmeneguello Is any chance to merge this PR as soon as possible ? Because it blocks us. Thanks in advance.

bkmeneguello commented 2 years ago

@AlKapkone the repo isn't mine. I just created the PR. You should probably ask @ChrisPates.

AlKapkone commented 2 years ago

@AlKapkone the repo isn't mine. I just created the PR. You should probably ask @ChrisPates.

Oh, I see. Sorry for disturbing you.