search

awslabs / ssosync

Populate AWS SSO directly with your G Suite users and groups using either a CLI or AWS Lambda
Apache License 2.0
530 stars 182 forks source link

golint failures #86

Closed ChrisPates closed 1 year ago

ChrisPates commented 2 years ago

Describe the bug

internal/aws/client.go:31:2: exported var ErrUserNotFound should have comment or be unexported
--
992 | internal/aws/http.go:20:6: type HttpClient should be HTTPClient
993 | internal/aws/mock/mock_http.go:25:6: type name will be used as mock.MockIHttpClient by other packages, and that stutters; consider calling this IHttpClient
994 | internal/aws/mock/mock_http.go:31:6: type name will be used as mock.MockIHttpClientMockRecorder by other packages, and that stutters; consider calling this IHttpClientMockRecorder
995 | internal/config/secrets.go:33:19: method SCIMEndpointUrl should be SCIMEndpointURL

To Reproduce Steps to reproduce the behavior:

golint -set_exit_status ./...

Expected behavior Clean run from golint

Additional context Add any other context about the problem here.