search

awslabs / ssosync

Populate AWS SSO directly with your G Suite users and groups using either a CLI or AWS Lambda
Apache License 2.0
528 stars 182 forks source link

Allows multiple user and group matches #89

Closed mike-carey closed 1 year ago

mike-carey commented 2 years ago

Issue #, if available:

Description of changes:

This allows multiple queries to google for user and group matches.

ssosync -g 'name:aws-*,email=group-1@example.com,email=group-2@example.com'

If none are provided, it still defaults to querying everything.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

mike-carey commented 2 years ago

Thanks for the feedback @steenzout. Please let me know if this implementation works for you. I am not able to request re-review. Is there anything else I should do to get this merged in?

steenzout commented 2 years ago

Thanks for the feedback @steenzout. Please let me know if this implementation works for you. I am not able to request re-review. Is there anything else I should do to get this merged in?

LGTM.

I'm not part of the @awslabs organization so I can't merge this either. I am also interested in the feature and performed an impromptu code review that's all.

mike-carey commented 2 years ago

Gotcha!! Thank you! I really appreciate your review.

ChrisPates commented 1 year ago

There desired functionality is being implemented under the feature branch feature-EnhancedMatch and will be released shortly.