search

awslabs / tough

Rust libraries and tools for using and generating TUF repositories
191 stars 43 forks source link

build(deps): bump url from 2.4.1 to 2.5.0 #724

Closed dependabot[bot] closed 5 months ago

dependabot[bot] commented 7 months ago

Bumps url from 2.4.1 to 2.5.0.

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
cbgbt commented 7 months ago

Hmm, odd that one of the tuftool tests failed on macos. Here's the relevant output for when the test logs are pruned:

running 4 tests
test clone_metadata_target_args_failure ... ok
test clone_full_repo ... ok
test clone_metadata ... FAILED
test clone_subset_targets ... ok

failures:

---- clone_metadata stdout ----
thread 'clone_metadata' panicked at 'assertion failed: `(left == right)`
  left: `""`,
 right: `"{\n \"signatures\": [\n  {\n   \"keyid\": \"4e777de0d275f9d28588dd9a1606cc748e548f9e22b6795b7cb

And this is the assertion that failed. I'm going to re-run the test while I peek at that code.

webern commented 7 months ago

I opened an issue: https://github.com/awslabs/tough/issues/734

cbgbt commented 5 months ago

After reading through the test source, I'm convinced that the issue is almost certainly some sort of filesystem/IO issue and couldn't possibly be related to a URL bump. I'm going to merge this PR.