search

awspring / spring-cloud-aws

The New Home for Spring Cloud AWS
http://awspring.io
Apache License 2.0
880 stars 299 forks source link

Upgrade AWS SDK to 1.12.261+ #460

Closed shresthaujjwal closed 2 years ago

shresthaujjwal commented 2 years ago

Type: High Security Vulnerabity

Component:

AWS SDK

Describe the bug Please upgrade AWS SDK To 1.12.261+ Origin: https://github.com/aws/aws-sdk-java/security/advisories/GHSA-c28r-hw5m-5gv3 Release Date: 2022-07-15

Vulnerability Details

The AWS SDK for Java enables Java developers to work with Amazon Web Services. A partial-path traversal issue exists within the `downloadDirectory` method in the AWS S3 TransferManager component of the AWS SDK for Java v1 prior to version 1.12.261. Applications using the SDK control the `destinationDirectory` argument, but S3 object keys are determined by the application that uploaded the objects. The `downloadDirectory` method allows the caller to pass a filesystem object in the object key but contained an issue in the validation logic for the key name. A knowledgeable actor could bypass the validation logic by including a UNIX double-dot in the bucket key. Under certain conditions, this could permit them to retrieve a directory from their S3 bucket that is one level up in the filesystem from their working directory. This issue’s scope is limited to directories whose name prefix matches the destinationDirectory. E.g. for destination directory`/tmp/foo`, the actor can cause a download to `/tmp/foo-bar`, but not `/tmp/bar`. If `com.amazonaws.services.s3.transfer.TransferManager::downloadDirectory` is used to download an untrusted buckets contents, the contents of that bucket can be written outside of the intended destination directory. Version 1.12.261 contains a patch for this issue. As a workaround, when calling `com.amazonaws.services.s3.transfer.TransferManager::downloadDirectory`, pass a `KeyFilter` that forbids `S3ObjectSummary` objects that `getKey` method return a string containing the substring `..` .

Publish Date: 2022-07-15

URL: CVE-2022-31159

maciejwalkowiak commented 2 years ago

Thanks for letting us know. Will make a release but keep in mind that you can bump AWS dependencies independently from Spring Cloud AWS, as described in docs.

shresthaujjwal commented 2 years ago

thank you, i agree we can override the dependencies but would rather prefer to use spring-cloud-aws-dependencies

maciejwalkowiak commented 2 years ago

Closed in #460