search

awspring / spring-cloud-aws

The New Home for Spring Cloud AWS
http://awspring.io
Apache License 2.0
841 stars 288 forks source link

Standalone Init DynamoDb Clients #768

Open driverpt opened 1 year ago

driverpt commented 1 year ago

Type: Feature

Is your feature request related to a problem? Please describe. Currently the DynamoDb AutoConfiguration is conditional on DynamoDbTemplate.

Describe the solution you'd like Standalone Initialization of DynamoDb + Enhanced Clients without Depending on DynamoDbOperations and DynamoDbTemplate

Describe alternatives you've considered Copy+Paste all initialization Logic to our own @Configuration

Additional context N/A

maciejwalkowiak commented 1 year ago

This would mean that DynamoDbTemplate bean is in a nested class in DynamoDbAutoConfiguration annotated with @ConditionalOnClass(DynamoDbTemplate.class).

I think it makes sense. Would you like to contribute a PR?

driverpt commented 1 year ago

Superseeded by #769

driverpt commented 1 year ago

@maciejwalkowiak , I would love to contribute with PR's. The question is, are you just going to reject them like you have previously done in the past ?

maciejwalkowiak commented 1 year ago

You're welcome to contribute PRs.

The question is, are you just going to reject them like you have previously done in the past ?

Are you sure you want to start this conversation like that?

driverpt commented 1 year ago

I just want to know if it's worth that I spend my time creating a PR, that's all

maciejwalkowiak commented 1 year ago

Start small with a PR for a single module. If it's good we will merge.