search

awspring / spring-cloud-aws

The New Home for Spring Cloud AWS
http://awspring.io
Apache License 2.0
885 stars 301 forks source link

Potential Conflict Warning #899

Closed aonurozcan closed 1 year ago

aonurozcan commented 1 year ago

Type: Bug

Component: SQS

Describe the bug Potential conflict between commons-logging:jar in spring-cloud-aws-starter-sqs dependency and Spring Framework.

It shows a warning on startup like below.

Standard Commons Logging discovery in action with spring-jcl: please remove commons-logging.jar from classpath in order to avoid potential conflicts

Sample Spring Boot version: 3.1.3 Spring Cloud Aws Version: 3.0.2

tomazfernandes commented 1 year ago

Hey @aonurozcan, thanks for bringing this up.

Not sure what to do about this - would you be able to provide a sample app that reproduces it so I can take a look?

Thanks.

aonurozcan commented 1 year ago

Hey @tomazfernandes

I'm sorry I just realized that it has nothing to do with awspring. It's related to spring-boot-starter-test and lombok.

Thanks

asenchuk commented 8 months ago

I had the same issue. commons-logging comes with aws sdk so I had to exclude it from all (I have 2) spring-cloud-aws starters

./gradlew dependencyInsight --configuration productionRuntimeClasspath --dependency commons-logging:commons-logging

> Task :dependencyInsight
commons-logging:commons-logging:1.2
  Variant runtime:
    | Attribute Name                 | Provided     | Requested    |
    |--------------------------------|--------------|--------------|
    | org.gradle.status              | release      |              |
    | org.gradle.category            | library      | library      |
    | org.gradle.libraryelements     | jar          | jar          |
    | org.gradle.usage               | java-runtime | java-runtime |
    | org.gradle.dependency.bundling |              | external     |
    | org.gradle.jvm.environment     |              | standard-jvm |
    | org.gradle.jvm.version         |              | 17           |

commons-logging:commons-logging:1.2
\--- org.apache.httpcomponents:httpclient:4.5.13
     \--- software.amazon.awssdk:apache-client:2.21.12
          +--- io.awspring.cloud:spring-cloud-aws-dependencies:3.1.0
          |    \--- productionRuntimeClasspath
          +--- software.amazon.awssdk:ses:2.21.12
          |    +--- io.awspring.cloud:spring-cloud-aws-dependencies:3.1.0 (*)
          |    \--- io.awspring.cloud:spring-cloud-aws-ses:3.1.0
          |         +--- io.awspring.cloud:spring-cloud-aws-dependencies:3.1.0 (*)
          |         \--- io.awspring.cloud:spring-cloud-aws-starter-ses:3.1.0
          |              +--- productionRuntimeClasspath (requested io.awspring.cloud:spring-cloud-aws-starter-ses)
          |              \--- io.awspring.cloud:spring-cloud-aws-dependencies:3.1.0 (*)
          \--- software.amazon.awssdk:s3:2.21.12
               +--- io.awspring.cloud:spring-cloud-aws-dependencies:3.1.0 (*)
               +--- io.awspring.cloud:spring-cloud-aws-s3:3.1.0
               |    +--- io.awspring.cloud:spring-cloud-aws-dependencies:3.1.0 (*)
               |    \--- io.awspring.cloud:spring-cloud-aws-starter-s3:3.1.0
               |         +--- productionRuntimeClasspath (requested io.awspring.cloud:spring-cloud-aws-starter-s3)
               |         \--- io.awspring.cloud:spring-cloud-aws-dependencies:3.1.0 (*)
               \--- io.awspring.cloud:spring-cloud-aws-s3-cross-region-client:3.1.0
                    +--- io.awspring.cloud:spring-cloud-aws-dependencies:3.1.0 (*)
                    \--- io.awspring.cloud:spring-cloud-aws-starter-s3:3.1.0 (*)
implementation ('io.awspring.cloud:spring-cloud-aws-starter-s3') {
    exclude group: 'commons-logging', module: 'commons-logging'
}
implementation ('io.awspring.cloud:spring-cloud-aws-starter-ses') {
    exclude group: 'commons-logging', module: 'commons-logging'
}
tomazfernandes commented 8 months ago

Seems like an issue with AWS SDK then? @maciejwalkowiak, anything we should do about this?