search

awth13 / org-appear

Toggle visibility of hidden Org mode element parts upon entering and leaving an element
MIT License
383 stars 19 forks source link

Upcoming breaking changes in org #52

Closed krisbalintona closed 1 year ago

krisbalintona commented 1 year ago

For me, I have org-hide-emphasis-markers set to t and use org-appear to show these emphasis markers (I have org-appear-trigger set to 'always). I'm currently on the master branch of org and noticed that org-appear does not work, that is, it does not reveal emphasis markers. (There are unhelpful errors as well when I try to enable/disable org-appear. They look similar to: Wrong type argument: number-or-marker-p, nil.)

After some investigation, I learned that the error was on org's side. Some further digger led me to isolate the commit that breaks org-appear's functionality: a8286a5a9e96f5192f9d74f46f5c55fbc1310168 from July 1, 2023. In the prior commit, org-appear works, where every commit henceforth org-appear is broken. This revision is one in the development of release_9.6.7; version 9.6.6 of org is compatible with org-appear still. It seems like there are big changes happening in org-element, according to the commit history.

As of making this issue (revision 879ba22ef69cc54d757b02e84d4f8d37dcef866f, to be precise), org is still broken. There is also the possibility that later commits also break org-appear.

As for what should be done, I will downgrade to org version 9.6.7, but I thought I should submit an issue anyway in case this problem persists with the full release of version 9.7.

krisbalintona commented 1 year ago

Update: I did some testing with --no-init and learned that it must've been related to some other part of my configuration. This is very strange since the backtrace of the error seemingly involved only org and org-superstar. I'm still not sure what caused the errors, but it is gone for me. So this "issue" can be closed