search

awth13 / org-appear

Toggle visibility of hidden Org mode element parts upon entering and leaving an element
MIT License
383 stars 19 forks source link

New Org 9.7.2 seems to break org-appear #58

Open technician77 opened 5 months ago

technician77 commented 5 months ago

It seem the just released org-mode 9.7 breaks the org-appear package. I get the error below. The built-in org-mode 9.6 works flawlessly with org-appear. Can you confirm?

Error

Error in post-command-hook (org-appear--post-cmd): (wrong-type-argument number-or-marker-p nil)

Versions

GNU Emacs 29.3 (build 2, x86_64-w64-mingw32) of 2024-03-24 Org mode version 9.7.2 (release_N/A-N/A-88dd2c @ c:/home/XXXXX/.emacs.d/elpa/org-9.7.2/)

Config

  (use-package org-appear
    :after org
    :custom
    (org-appear-autolinks t)
    (org-appear-autokeywords t)
    (org-appear-autoemphasis t)
    (org-appear-autoentities t)
    :hook
    (org-mode . org-appear-mode))

Kind regards tech77

awth13 commented 5 months ago

Thank you for the detailed report, @technician77!

This is going to take some time to resolve as there were substantial changes in org-element between versions. In the meantime, org-9.7-fixes has emphasis toggling working (other elements may or may not work).

agzam commented 4 months ago

Another issue with 9.7. Links are not expanding.

Error running timer ‘org-appear--show-with-lock’: (error "org-link is not a valid folding spec")
Error in post-command-hook (org-appear--post-cmd): (error "org-link is not a valid folding spec")
awth13 commented 4 months ago

Thanks, @agzam. Should be fixed in 21fbfdd6f0b440136c03243a976d9cfa049bed9b.

Kazark commented 4 months ago

This fixed it for me, thanks. :tada:

fnussbaum commented 4 months ago

I am a little bit confused, because when I first upgraded to Org 9.7 I got the same error: 

Error in post-command-hook (org-appear--post-cmd): (wrong-type-argument number-or-marker-p nil)

However, it seemed to me that the error was caused by incorrect byte compilation, maybe due to package.el using an old Org version during compilation of org-appear. Reinstalling org-appear and trough trial-and-error ensuring correct byte-compilation made the error go away. In particular toggling emphasis markers and sub- and superscripts has been working fine for me since 9.7 was released, and without https://github.com/awth13/org-appear/tree/org-9.7-fixes.

pmiddend commented 2 months ago

I have org-version 9.7.11 and org-appear doesn't work at all. Nothing is hidden. Could this be another 9.7 issue?

Jousimies commented 2 months ago

+1