awtkns / fastapi-crudrouter

A dynamic FastAPI router that automatically creates CRUD routes for your models
https://fastapi-crudrouter.awtkns.com
MIT License
1.34k stars 156 forks source link

Feature/poetry #158

Closed dclimber closed 2 years ago

dclimber commented 2 years ago

Resolves #156

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
fastapi-crudrouter ✅ Ready (Inspect) Visit Preview Jul 3, 2022 at 7:46AM (UTC)
dclimber commented 2 years ago

Whoops, did not run the tests — my bad. There seems to be some issues with the resolved pydantic version. Working on it.

awtkns commented 2 years ago

Hi @dclimber, thanks for this! This is a solid improvement. My main concern here is dropping support for python 3.6. As fastapi supports python 3.6 so should this library.

The one caveat here is that the tortoise-orm CRUDRouter is not available to those using python 3.6.

Curious on your thoughts. Thanks again for thsi!

dclimber commented 2 years ago

@awtkns phew everything works finally.

awtkns commented 2 years ago

@dclimber I think the github workflows may need to be changed so that they support poetry

dclimber commented 2 years ago

@awtkns hmm yeah it seems. I have python 3.8 on my system, so things work smoothly, but other versions need testing. I'll look into either workflow improvement with poetry or fixing things, so existing workflows pass.

dclimber commented 2 years ago

@awtkns pipelines finally pass! https://github.com/dclimber/fastapi-crudrouter/pull/3

awtkns commented 2 years ago

Thanks for the great work @dclimber. I've seen that you have been active on some other issues. Let me know if there is any way I can support 🚀