Closed dclimber closed 2 years ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
fastapi-crudrouter | ✅ Ready (Inspect) | Visit Preview | Jul 3, 2022 at 7:46AM (UTC) |
Whoops, did not run the tests — my bad. There seems to be some issues with the resolved pydantic version. Working on it.
Hi @dclimber, thanks for this! This is a solid improvement. My main concern here is dropping support for python 3.6. As fastapi
supports python 3.6 so should this library.
The one caveat here is that the tortoise-orm CRUDRouter is not available to those using python 3.6.
Curious on your thoughts. Thanks again for thsi!
@awtkns phew everything works finally.
@dclimber I think the github workflows may need to be changed so that they support poetry
@awtkns hmm yeah it seems. I have python 3.8 on my system, so things work smoothly, but other versions need testing.
I'll look into either workflow improvement with poetry
or fixing things, so existing workflows pass.
@awtkns pipelines finally pass! https://github.com/dclimber/fastapi-crudrouter/pull/3
Thanks for the great work @dclimber. I've seen that you have been active on some other issues. Let me know if there is any way I can support 🚀
Resolves #156
pyproject.toml
with poetry config.poetry.lock
— all dependencies are here.requirements.txt
anddev.requirements.txt
— exported from poetry, so no conflicting package versions are installed.contributing.md
with info about poetry.psycopg2
topsycopg2-binary
to avoid buildingpsycopg2
.