search

awtterpip / bevy_oxr

Apache License 2.0
253 stars 39 forks source link

Initial D3D12 implementation + improvements #50

Closed SafariMonkey closed 9 months ago

SafariMonkey commented 1 year ago

Thank you for taking a look, @TheButlah!

I have a guest this weekend so I will make the changes when I find the time.

Most of the comments were good points but relate to things I copied from the other driver, so I'll apply those changes as separate commits that make the same change on both sides.

SafariMonkey commented 11 months ago

Force push was rebasing and and squashing a little

SafariMonkey commented 11 months ago

Squashed in removing some unused imports

SafariMonkey commented 11 months ago

Set as draft to reflect an outstanding issue: got errors on Vulkan on Oculus PC because it doesn't select Rgba8UnormSrgb, but instead Rgba8Unorm; need to investigate why that causes problems. Could probably change to use a hardcoded format and bail if the runtime doesn't support it if we wanna defer that work.

TheButlah commented 11 months ago

Could probably change to use a hardcoded format and bail if the runtime doesn't support it if we wanna defer that work.

I suggest that approach, to prevent this PR from getting stale. I would open a subsequent PR to fix that particular issue after this is merged.