search

ax / apk.sh

apk.sh makes reverse engineering Android apps easier, automating some repetitive tasks like pulling, decoding, rebuilding and patching an APK.
GNU General Public License v3.0
3.34k stars 189 forks source link

[BUG] Positional args never used #17

Closed Starmania closed 1 year ago

Starmania commented 1 year ago

Information

  1. apk.sh version : v1.0.4
  2. Operating System (Mac, Linux, Windows) : N/A
  3. APK From? (Playstore, ROM, Other) : N/A

apk.sh output

N/A

Steps to Reproduce

  1. Run any command accepting positional args (build, decode, patch)
  2. Theses args are saved but never used

Questions to ask before submission

This StackOverflow answer seems to have been a source when this file was created. But some things are missing (the definition of the POSITIONAL_ARGS variable and the restoration of positional parameters)...

ax commented 1 year ago

It's a feature! :beetle:

Starmania commented 1 year ago

It's a feature, I accept... I will make a PR one of theses days... So it would really be a feature

ax commented 1 year ago

👀

On Tue, Sep 5, 2023, 7:09 PM Romain @.***> wrote:

🧐🧐

— Reply to this email directly, view it on GitHub https://github.com/ax/apk.sh/issues/17#issuecomment-1706996580, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2XGBMOJSAJZTG6ASD25HLXY5MFBANCNFSM6AAAAAA2ONRT54 . You are receiving this because you modified the open/close state.Message ID: @.***>