axa-ch-webhub-cloud / pattern-library

AXA CH UI component library. Please share, comment, create issues and work with us!
https://axa-ch-webhub-cloud.github.io/plib-feature/develop
126 stars 17 forks source link

Getting Startet React example mistake #2192

Closed tim-dubath closed 3 years ago

tim-dubath commented 3 years ago

Getting Startet React example mistake

Expected Behavior

It should work if you just copy and paste the example.

Current Behavior

It can't find the name AxaButtonReact

Steps to Reproduce

https://patterns.axa.ch/?path=/story/guides-getting-started--getting-started Scroll down to the React section and copy the Code.

Context (Environment)

It's nothing that concerns me but the example code from the pattern library should already work with copy and paste.

Windows 10, IntelliJ IDEA 2020.2

Possible Solution

import {createElement} from 'react'; import createAXAButtonReact from '@axa-ch/button/lib/index.react';

const AXAButtonReact = createAXAButtonReact(createElement);

I am a Button

Of course you could also add an onClick function

This form does not allow me to paste my code. For this reason I could send it to you via email. However, I do not know your email address. Therefore I ask you to send me an e-mail at: tim.dubath@axa.ch

Kind regards Tim Dubath

LucaMele commented 3 years ago

@tim-dubath thank you very much for the submission, we will look at it and comment here our result. Please note, if you need to contact us, you can find details here: https://patterns.axa.ch/?path=/story/others-contact--contact

tim-dubath commented 3 years ago

@LucaMele Hi Luca, I just noticed it is in every single component on the usage Tag. In the open-tag you write AXA in Caps and in the close tag you write it "Axa". I noticed it only in the react "usage" part.

01231 commented 3 years ago

Ups, didn't see your issue and opened a similar one.

raphaellueckl commented 3 years ago

This is fixed now, thx.