search

axa-ch-webhub-cloud / pattern-library

AXA CH UI component library. Please share, comment, create issues and work with us!
https://axa-ch-webhub-cloud.github.io/plib-feature/develop
126 stars 17 forks source link

Button Link doesn't change height to show long text when styled with a width #2234

Closed stefan-kueenzi closed 2 years ago

stefan-kueenzi commented 3 years ago

Expected Behavior

Button Link changes height to show long text when styled with a width

Current Behavior

Button Link doesn't change height to show long text when styled with a width.

Steps to Reproduce

Go to https://patterns.axa.ch/?path=/story/components-button-link--button-link Set a long text for the button Use Browser DevTools to set width of the Button Link

Possible Solution

Should have same behavior as the Button, which changes it's height for a long text.

markus-walther commented 2 years ago

Screen Shot 2022-07-25 at 11 25 26 I did exercise the steps you listed and could not reproduce the issue (see screenshot above).

stefan-kueenzi commented 2 years ago

2 Lines of text fit within the 40px of the default height. Maybe try with a text that would need more than 2 lines to display?

markus-walther commented 2 years ago

Yes, further testing reveals the problem occurs with long-enough text. Will discuss with the team. It would have been good to be precise with what text has been tested and show the level of detail that I showed with my screenshot.