axa-ch-webhub-cloud / pattern-library

AXA CH UI component library. Please share, comment, create issues and work with us!

https://axa-ch-webhub-cloud.github.io/plib-feature/develop

125 stars 18 forks source link

Rework component versioning's central workhorse function #2398

Closed markus-walther closed 1 year ago

markus-walther commented 1 year ago

....defineVersioned for easier auditing and maintenance.

Fixes #

Merge Checklist:

[ ] Code selfreview has been performed (Best Practices).
[ ] Tests are sufficient.
[ ] Documentation is up to date.
[ ] Changelog is up to date.
[ ] Typescript typings for properties are up to date.
[ ] Designers approved changes or no approval needed.
[ ] Dependencies to other components still work.

markus-walther commented 1 year ago

Marco Kruse writes regarding a potential reason why this PR still leads to test failures: 23:04 Uhr http://localhost:6006/?path=/story/examples-dropdown-react--dropdown-uncontrolled 23:06 Uhr Wenn du storybook oeffnest siehst du error in der console und paar Test failen eventuell liegt es hier ran. export const numericalVersion = window.customElements.get('axa-dropdown').versions['axa-dropdown']; in AXADropdownVersionedReact.jsx (bearbeitet)