axa-ch-webhub-cloud / pattern-library

AXA CH UI component library. Please share, comment, create issues and work with us!
https://axa-ch-webhub-cloud.github.io/plib-feature/develop
125 stars 18 forks source link

allow html min and max properties #2405

Open ahoehn opened 1 year ago

ahoehn commented 1 year ago

Fixes #

Merge Checklist:

markus-walther commented 1 year ago

Hello Adrian Höhn,

thanks for submitting a PR!

Can you please open an issue that clearly describes the problem that your PR desires to fix? Then you can actually fill in the Fixes # ! I think that issue is a Feature request, so the label should be set that way. Then, you might want to review lit-html template syntax here: https://lit.dev/docs/v1/lit-html/template-reference/#binding-types. Seems your min/max properties are using the syntax for Boolean attributes, which is probably not what you want. Since you did not add any Playwright tests, you might want to add some to test your new feature - and only then check the checkbox above. Same for README.md documentation.

Thanks for working with us to get this into good shape.

Cheers, Markus