axa-group / nlp.js-app

MIT License

132 stars 58 forks source link

Fix entity languages #53

Closed qwertyuu closed 4 years ago

qwertyuu commented 5 years ago

Pull Request Template

PR Checklist

[ ] I have run npm test locally and all tests are passing.
[ ] I have added/updated tests for any new behavior.
[ ] If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

The language copied to the trained JSON file was "undefined" in my case. I had to trace back where the languages were taken from and found that language became languages in the example entity, and that manager.languages did not exist anymore and was moved to manager.settings.languages

qwertyuu commented 5 years ago

@jesus-seijas-sp I can't run the tests. All of them fail. What am I doing wrong? Also when I run npm run test, the first part of the command fails:

ESLint: 5.16.0.
No files matching the pattern "lib/**" were found.

If I try jest --coverage --maxWorkers=4 as-is, they run but all fail.