search

axblk / teeworlds

A retro multiplayer shooter
http://teeworlds.com
Other
11 stars 2 forks source link

Support other race gametypes? #28

Closed axblk closed 4 years ago

axblk commented 5 years ago

Maybe merge (especially team-based) gametypes like DDRace or HpRace.

Dune-jr commented 5 years ago

Maybe that would be for the best. If you go with it and design some sort of interface that says IsDDRace(), I can set up a (functional) pull request from https://github.com/axblk/teeworlds/compare/race...Dune-jr:ddr?expand=1

There isn't much work done though, so you might want to work it a completely different way

axblk commented 5 years ago

I'll add some kind of IsDDRace() check. One important thing is that Race needs a fully functional ninja. There are not too many maps using it but I'd prefer to not break them. There could also be some problems with the map-settings. DDRace uses some additional options and has other defaults as far as i remember. For now it should be fine to just merge it and set the appropriate defaults in the corresponding game-controller.

Dune-jr commented 5 years ago

Sounds good. I foresee no problem with the ninja, the culprit code can easily be encapsulated in a if(IsDDrace()). In fact, I suspect ninja pickups still work like they would in vanilla on my branch :)

axblk commented 4 years ago

Won't fix. This mod concentrates on solo race.