Closed szaydel closed 2 years ago
I think we should just include it unconditionally, that should be safe. Hopefully... I'll give it a go.
Yeah, it should be harmless, but I figured I would minimize the affect at least in my own testing. It seems like we are trying not to have any system level includes in this file, which was another reason for trying to limit blast radius.
I did push a fix, so feel free to close this one provided it works for you now.
Yup, LGTM. Thanks a lot for getting this incorporated quickly, I appreciate it!
Please acknowledge the following before creating a ticket
Description of the bug: Observing the following when no changes are made building from master.
With the following change I am able to build without a problem.
This is is likely not the most correct approach, but it works. I would not mind fixing this so that it correctly built on Omni.
Environment:
fio version: Latest ref on the master branch
Reproduction steps