search

axboe / fio

Flexible I/O Tester
GNU General Public License v2.0
5.21k stars 1.26k forks source link

docs: use "delete" term instead of "unlink", which is less common #1742

Closed edigaryev closed 6 months ago

edigaryev commented 6 months ago

This way people would have an easier time discovering this command-line option, see https://github.com/axboe/fio/issues/1739.

axboe commented 6 months ago

I'm fine adding "delete" in there as well, but don't get rid of unlink. It may not mean anything to you, but it's a very commonly used word and in fact fully reflects what is being done here. As you may have noticed, it's what the option is called as well.

edigaryev commented 6 months ago

I'm fine adding "delete" in there as well, but don't get rid of unlink.

See https://github.com/axboe/fio/pull/1742/commits/4efb3c69db5bf39f74a357feeed1c79f8fb0ae25.

axboe commented 6 months ago

I think you missed some of your changes, and please squash them into one commit.

edigaryev commented 6 months ago

I think you missed some of your changes, and please squash them into one commit.

Good catch, see https://github.com/axboe/fio/pull/1742/commits/3fe133a51a9c51052388a7b6a1cd8ff0a67746b6.