search

axc450 / pbs

Battle Pet Combat Scripting
MIT License
24 stars 11 forks source link

Rematch5 compatibility #56

Closed bloerwald closed 11 months ago

axc450 commented 11 months ago

Thanks all for all work on this. This is a big milestone to get working with Rematch 5. I think supporting Rematch 4 for now is OK (but it should be easy to remove in the future)

gizzmo commented 11 months ago

Thanks all for all work on this.

My pleasure, I really wanted to try the Rematch 5 beta, but can't live without this amazing addon. (Bonus I enjoy coding 😉)

bloerwald commented 11 months ago

The initial load needs to happen either at the same time, or after Rematch5.

If you've used Rematch5, do a /rematch reset everything

  • Logout and apply my changes
  • Log into the game and pray things work.

We can't keep that UX, people will complain too much since our releases are unlikely to line up perfectly.

bloerwald commented 11 months ago

Bug: Script manager has all script names, but shows neither the matching team, nor the script content.

There not being a matching team is also the case when mouse-overing the icon in the script editor. The script content exists there though.

Only happens directly after conversion, a single reload fixes, so probably some missing event.

bloerwald commented 11 months ago

UX: Notes in teams list is a button but we only get a badge. People will want the old UX back where clicking the badge opens the editor. Check with Rematch whether we can have that again.

We can't. Wait until Gello reimplements that in a later update, I guess.

bloerwald commented 11 months ago

closing: #61 was superset and is merged