axcap / Esp-GitHub-OTA

Arduino OTA updater that uses Github releases as storage
13 stars 8 forks source link

Is this working with private repos? #11

Open zekageri opened 1 year ago

axcap commented 1 year ago

Not right now, but depending on the amount of work it may be added later.

zekageri commented 1 year ago

This is the release url format if you want to start it

define RELEASE_URL "https://{GITHUB_TOKEN}@api.github.com/repos/{USER_NAME}/{REPO_NAME}/releases/latest"

https://github.com/settings/tokens

I was able to fetch the latest with this syntax. Now i try to download it.

bfokin commented 7 months ago

@zekageri are you able to utilize it currently? I just keep getting a 404 error.

zekageri commented 7 months ago

I have made my own implementation which is worked great but interestingly i started to get 404 error too. It seems github does not like the api keys so far.

bfokin commented 7 months ago

Do you know of any other way that works by chance?

zekageri commented 7 months ago

Unfortunately not. But I will move my firmwares to my own server soon because github has rate limits and its a third party which i cant rely on. Render.com has a rellay good free tier and you can host a node.js server there.

axcap commented 7 months ago

Thank you for noticing, I will investigate this further.

axcap commented 7 months ago

@bfokin @zekageri I just tested it with classic personal access token and it worked for me (vua curl in terminal). But i can confirm that i too get 404 when accessing the same url via browser (chrome or safari).

curl -L https://ghp_qj....2TGB2420vRY@api.github.com/repos/{owner}/{private_repo}/releases

Make sure you give access to repo scope as shown in the picture below:

Screenshot 2024-03-19 at 09 41 08