axcell-0 / Ruby-Capstone

MIT License
1 stars 0 forks source link

Kanban Board Setup #16

Open hamidazim321 opened 10 months ago

hamidazim321 commented 10 months ago

We are a group of 4:

  1. Thierry Noumbuh (Team member 1)
  2. Hamid Azim (Team member 2)
  3. Mohammad Faiz (Team member 3)
  4. Sam Lemma (Team member 4)

The Github Project Link:

topeogunleye commented 10 months ago

Hi @hamidazim321, @sam2if, @axcell-0, @the-faizmohammad,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

dwayne-the-rock

🚀 Highlights:

  1. Organization and Modularity:

    • Excellent job creating separate .rb files for each class, promoting code modularity.
    • Well-defined constructors for each class, adhering to the specified properties.
  2. Method Implementation:

    • Thorough implementation of all methods as outlined in the requirements.
    • Custom setter methods for 1-to-many relationships appropriately used, enhancing code readability.
  3. Unit Testing:

    • Impressive inclusion of unit tests for all implemented methods, ensuring robustness.
    • Demonstrates a commitment to code quality and reliability.
  4. Database Schema Design:

    • Comprehensive creation of schema.sql files, mirroring class structures accurately.
    • Tables for books, music albums, games, and movies include necessary properties and associations.
  5. User Interaction:

    • Well-designed console app entry-point (main.rb) with clear user options and parameter handling.
    • Implementation of startup actions ensures a user-friendly experience.
  6. Data Preservation:

    • Proper use of .json files for preserving data in collections, aligning with the project requirements.

🌟 Overall Impression:

🙏 Thank you for your dedication and hard work. Looking forward to seeing the project progress! 🚀

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

You can also consider:

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag @topeogunleye in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.