vertigo220
commented
1 year ago To add to this, it's inconsistent as to when it complains about this. If I try to download a video with the format set to default, it will just download the audio file then error immediately, but if I select mp4 it downloads the video then errors (note I would have included the errors as they're slightly different, but for some reason there's no capability to copy them). And these errors only occur if I manually select a quality (1440p60 in this case), whereas leaving the quality at default (highest) works without error even when format is set at default, which causes it to error with the quality selected. And, while a separate issue, I'll just mention that I have to select the quality since it fails to grab the highest quality when set to do so, and instead only gets the 720 version.
yt-dlp is fully updated, btw.
axcore
What operating system are you using?
Win10
What version of Tartube are you using?
2.4.260
Details
Whenever I try to download and convert, it downloads then errors saying nothing happened. For starters, this is a problem because that's not entirely true, and it makes it seem like the download failed, when in fact it downloaded the desired video but then couldn't convert it. This could cause users to redownload something again not realizing it's already on their computer (and I've done so). So that's one problem, and perhaps should be its own issue.
But the real problem is that it's saying FFmpeg isn't installed, when it's not only installed, but it's in %PATH% and so is readily accessible to any program without even having to look for it, and it won't let me set the path to it, with the only option apparently being to install it, which I shouldn't have to have multiple "installs" of it in different locations, especially given its size, nor should I have to download it to "install" it with Tartube, a particular problem since I'm on a somewhat slow mobile connection for internet.
Proposed solution
For starters, it should be able to find ffmpeg considering it's in the path variable. Basic batch scripts I've written that use it first check to see if it's available, and only if it's not do they then find it on their own by simply performing a search with "where." I see no reason why Tartube couldn't do these things. Second, it should allow manually setting the path. And third, the error message should be more descriptive, specifying that the file was downloaded but conversion couldn't be done, not that "nothing happened."