search

axcore / tartube

A GUI front-end for youtube-dl, partly based on youtube-dl-gui and written in Python 3 / Gtk 3
GNU Lesser General Public License v2.1
2.05k stars 111 forks source link

Show system command output format #576

Closed mbnoimi closed 1 year ago

mbnoimi commented 1 year ago

Current version doesn't output a correct system command because it's missing double quotes in many passed arguments as shown below.

May you please fix this issue?

Command output

What operating system are you using?

Linux Mint 21.2

What version of Tartube are you using?

v2.4.407

mbnoimi commented 1 year ago

BTW, passing --match-filter !is_live shows this error:

bash: !is_live: event not found

So I forced to delete it in the corrected command

axcore commented 1 year ago

Tartube does not send the whole command to the system; instead, it passes arguments to the system, one at a time.

Therefore, the "missing" quotes are not necessary. In fact, if we try to add them, yt-dlp will generate an error.

axcore commented 1 year ago

BTW, passing --match-filter !is_live shows this error

I tested it on this video, but I didn't see the same error. Can you give me a video URL that generates this error?

mbnoimi commented 1 year ago

BTW, passing --match-filter !is_live shows this error

I tested it on this video, but I didn't see the same error. Can you give me a video URL that generates this error?

/home/laptop/.local/bin/yt-dlp --newline -i --match-filter !is_live -r 200K -R 99 --hls-prefer-native --no-mtime --cookies /home/laptop/Downloads/youtube-dl/cookies.txt -x --audio-format m4a --audio-quality 0 --embed-thumbnail --fixup detect_or_warn --break-on-existing --write-link --embed-metadata --reject-title CANLI|saat|UZUN|live|radyo --output /home/laptop/Downloads/youtube-dl/downloads/Audio/Apocalyptica/%(title)s.%(ext)s --continue --match-filters !is_live --download-archive /home/laptop/Downloads/youtube-dl/downloads/Audio/Apocalyptica/ytdl-archive.txt https://www.youtube.com/c/apocalyptica/videos
mbnoimi commented 1 year ago

Therefore, the "missing" quotes are not necessary. In fact, if we try to add them, yt-dlp will generate an error.

If you copied the generated system command and pasted it into the terminal you'll get many errors related to invalid command format!

axcore commented 1 year ago

I downloaded all 300 videos, but I didn't see the same error

apoca

If you copied the generated system command and pasted it into the terminal you'll get many errors related to invalid command format!

I understand that, but if I add artificial quotes to the displayed text, then we are not seeing the actual system command, but an imaginary one.

mbnoimi commented 1 year ago

I understand that, but if I add artificial quotes to the displayed text, then we are not seeing the actual system command, but an imaginary one.

I can't explain more. Please see the screencast (in case there is a any space in the paths or names the download will fail, same problem for any special character)

https://github.com/axcore/tartube/assets/284547/c1c7b2bc-7f6f-44be-9c1b-1337646126cf

axcore commented 1 year ago

Ok, I did not understand that your --match-filter problem only happens in the terminal window.

matchfilter

I don't know why yt-dlp does that, you will have to ask the yt-dlp guys :)

axcore commented 1 year ago

About your first question:

Changing the Tartube code, so that it displays "..." in the Output tab, is not a simple task. It is probably a whole day or maybe two days of work.

axcore commented 1 year ago

I added quotes in v2.4.412. The updated code is not very sophisticated, but it will do what you want (most of the time).

mbnoimi commented 1 year ago

I added quotes in v2.4.412. The updated code is not very sophisticated, but it will do what you want (most of the time).

Thank you. I'll test it soon