search

axcore / tartube

A GUI front-end for youtube-dl, partly based on youtube-dl-gui and written in Python 3 / Gtk 3
GNU Lesser General Public License v2.1
1.92k stars 105 forks source link

Video Sorting is not always triggered #611

Closed tsk-2222 closed 5 months ago

tsk-2222 commented 5 months ago

What operating system are you using? Windows 10

What version of Tartube are you using? v2.4.429

Reverse sort does not trigger properly. To Reproduce: When starting from a normal sort; Clicking reverse sort does nothing and clicking the 'resort videos' icon does nothing. You can then trigger the sorting function by right clicking on any video, click show video, click properties, click OK. At that point the sort function will be triggered to reverse sort the videos. BTW, leaving the folder and returning to the folder will also cause the sort order to be wrong.

When you are in reverse sort order then clicking the 'undo reverse sort' icon will work properly.

Additionally, non alphabet characters are being included in the sort. For instance the text "Watch This" will be sorted first when in alphabetical order.

axcore commented 5 months ago

Reverse sort does not trigger properly

I have fixed his problem, but...

Additionally, non alphabet characters are being included in the sort.

I can't reproduce it; non-alphabetic characters should not affect the sort. Please give me the URL of a channel or playlist, which demonstrates this broken behaviour.

tsk-2222 commented 5 months ago

Here's a video that starts with quotes: https://www.youtube.com/watch?v=D090T2MSxKY When sorted by name, the video title: "I Will Always Love You" Linda Ronstadt will be sorted before all other videos because the ascii for the quote character in the title comes before the ascii for any letter or number.

Perhaps the sort should be by uppercase letters and numbers only and exclude other characters.

axcore commented 5 months ago

The reverse sort problem is fixed in v2.5.0. I haven't checked the other problem yet.

axcore commented 5 months ago

Additionally, non alphabet characters are being included in the sort.

I fixed this in v2.5.003. The new code is uploaded only to github/pypi; Windows users can update their installation as described here.