axcore / tartube

A GUI front-end for youtube-dl, partly based on youtube-dl-gui and written in Python 3 / Gtk 3
GNU Lesser General Public License v2.1
2.05k stars 111 forks source link

PNG thumbnails deleted and not embeded #626

Open adenry opened 6 months ago

adenry commented 6 months ago

OS: Windows 10 Tartube version: 2.5.0

As the title says, when I download videos that have PNG thumbnails, I can see the thumbnail successfully downloaded, but then just before it'd be embeded into the video, it gets deleted (and, naturally, not embeded).

When I pass the EXACT same command (copy-paste from Tartube Output) to a separate instance of yt-dlp.exe that I downloaded directly from the yt-dlp github, this issue does not happen, the thumbnail is downloaded and embeded into the video.

Here's Tartube's output:

python3 -X utf8 ..\..\..\mingw64\bin\yt-dlp.exe --newline -i --hls-prefer-native --write-description --write-info-json --cookies C:/Users/user/Downloads/Tartube/cookies.txt --write-thumbnail --write-sub --all-subs --embed-subs --embed-thumbnail --add-metadata --fixup warn --windows-filenames --ignore-no-formats-error --output "D:/test/%(title)s.%(ext)s" https://www.starwars.com/video/trailer-the-bad-batch
[Disney] Extracting URL: https://www.starwars.com/video/trailer-the-bad-batch
[Disney] trailer-the-bad-batch: Downloading webpage
[Disney] 5beb54f010f3bebd6b4f2a72: Downloading m3u8 information
WARNING: [Disney] Ignoring subtitle tracks found in the HLS manifest; if any subtitle tracks are missing, please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
[info] 5beb54f010f3bebd6b4f2a72: Downloading subtitles: en_us
[info] 5beb54f010f3bebd6b4f2a72: Downloading 1 format(s): mp4-4007
[info] Writing video description to: D:/test/Official Trailer - Star Wars: The Bad Batch.description
[info] Writing video subtitles to: D:/test/Official Trailer - Star Wars: The Bad Batch.en_us.srt
[download] Destination: D:/test/Official Trailer - Star Wars: The Bad Batch.en_us.srt
[download] 100% of    2.53KiB in 00:00:00 at 158.97KiB/s
[info] Downloading video thumbnail 0 ...
[info] Writing video thumbnail 0 to: D:/test/Official Trailer - Star Wars: The Bad Batch.png
[info] Writing video metadata as JSON to: D:/test/Official Trailer - Star Wars: The Bad Batch.info.json
[download] Destination: D:/test/Official Trailer - Star Wars: The Bad Batch.mp4
[download] 100% of   59.39MiB in 00:00:05 at 10.27MiB/s
[EmbedSubtitle] Embedding subtitles in "D:/test/Official Trailer - Star Wars: The Bad Batch.mp4"
[Metadata] Adding metadata to "D:/test/Official Trailer - Star Wars: The Bad Batch.mp4"
WARNING: Skipping embedding the thumbnail because the file is missing.

I tried disabling webp to jpg convesion in System preferences (as suggested here https://github.com/axcore/tartube/issues/461 ) but that didn't help. Also, the "...but don't delete the original thumbnails" option is enabled.

Here are links to this video and a couple others like that that have this issue (all have PNG thumbnails): https://www.starwars.com/video/trailer-the-bad-batch https://www.starwars.com/video/season-2-official-trailer-star-wars-the-bad-batch https://www.starwars.com/video/extraction-star-wars-the-bad-batch

Here are links to videos that have JPEG thumbnails instead, and don't have this issue: https://www.starwars.com/video/sizzle-the-bad-batch https://www.starwars.com/video/featurette-meet-the-the-bad-batch

One last thing - when I open one of those PNG thumnails with IrfanView, it says it is actually not a PNG, but a JPG. Maybe that's part of the issue?