search

axe-me / laravel-graphql-upload

GraphQL Upload middleware for Laravel and Lumen
MIT License
0 stars 1 forks source link

webonyx/graphql-php legacy dependency #1

Open ievgenklymenko opened 6 years ago

ievgenklymenko commented 6 years ago

Hi, nice port! And probably only good way to handle uploads 👍 However it has very old webonyx/graphql-php dependency (^0.10.2 is more than a year old) and since it's pre-1.0 version it doesn't even want to work alone 0.11.*... Is it possible to update dependency or would it break anything? Would be nice if possible!

axe-me commented 6 years ago

The reason I leave it there is I use the https://github.com/Folkloreatelier/laravel-graphql, and this package use 0.10. I guess I should remove the dep, or update and tag a new release Not sure if I remove the dep would break anything, I only use that for define the upload type. I have to test it. But I'm working right now, so I will do it this weekend, can you wait? or you can create a PR.

ievgenklymenko commented 6 years ago

That's fine! Thanks for looking into it :)