search

axe-me / vite-plugin-node

Vite plugin to run your node dev server with HMR!
990 stars 46 forks source link

Node12 support #23

Closed beefancohen closed 2 years ago

beefancohen commented 2 years ago

hi! thanks for creating this plugin -- is there anything preventing setting the min engine for node to 12? it didn't seem like there was anything egregious. unfortunately, i don't have control over the node version we use in our environment.

thanks! ethan

sidwebworks commented 2 years ago

Hey @evcohen turns out vite itself requires a node version of minimum of >=12.0.0 You can read more here, https://vitejs.dev/guide/#scaffolding-your-first-vite-project

So I don't think so it would be possible without messing with Vite's internals itself.

beefancohen commented 2 years ago

ah yeah, but this package has it's engine set to:

 "engines": {
    "node": ">=14.0.0"
  },

my work env is on 12.18.2, so i can't install this (but i can install vite itself)

sidwebworks commented 2 years ago

Ah my bad, i thought you wanted the minimum env to go below 12.

I think I could try running a fork on v12 if everything goes well I guess it should be fine to change the min env to >=12 right @axe-me ?

axe-me commented 2 years ago

Thanks guys for reporting this. Let me remove the node version requirement.

The reason I had it in there was that m1 chip problem I had before. I guess that is not an issue for everyone.

axe-me commented 2 years ago

0.0.15 released

beefancohen commented 2 years ago

thank you!