search

axe312ger / gatsby-transformer-inline-svg

Read and optimize SVG file nodes to render them inline in your website.
12 stars 11 forks source link

Feature: support for DatoCMS source #91

Open Hless opened 2 years ago

Hless commented 2 years ago

Added the feature, tets and documentation.

Would be a great addition for those using Dato

Hless commented 2 years ago

One thing to note: I slightly changed the caching key, it now includes the provider in the key (so caching is different for each source). I'm not sure if this is a useful change, but it made sense as this transformer would now service multiple sources

Hless commented 2 years ago

Added: resolver for DatoCmsFileField, otherwise the resolver would not be usuable for files added to other models.

axe312ger commented 1 year ago

Sorry I overlooked this 🙈

Could you fix the typo pls?

I'll then try to run it on my machine, as GH won't run the CI

Hless commented 1 year ago

Fixed the typo, but apparently my last few commits weren't signed properly. Have to check what happened here

Hless commented 1 year ago

Just realized I don't sign commits locally at all, is this something that is absolutely required for the merge?

axe312ger commented 1 year ago

Nono, its just that the CI won't run then. I'll have to test locally.