search

axegon / SkLite-dart

Transpile scikit-learn models to Flutter
MIT License
37 stars 14 forks source link

Null safety #7

Closed TornadoStorm closed 1 year ago

TornadoStorm commented 2 years ago

This repository unfortunately hasn't been updated to have null safety. I have tested the repo from the pull request being made by @SebghatYusuf, but it, unfortunately, has a couple of bugs that needed to be ironed out. So far my fork of his fork seems to work in a stable condition. Please implement null safety or let me know if you want a merge from my branch :)

axegon commented 1 year ago

could you open a pr?

TornadoStorm commented 1 year ago

Sure! I'll get to it soon. I only made quick hotfixes for a small project so not sure whether it's entirely stable.

axegon commented 1 year ago

Appreciated!

Parfyonator commented 1 year ago

Hi @axegon.

That's great. Would you be able to update the package at pub.dev? It still can be used though the github dependency in pubspec but I guess it would be more convenient to get it from pub.dev.

axegon commented 1 year ago

@Parfyonator you're right, thanks for bringing it up(and sorry for the delay, I don't go on github often). It's been published under version 1.0.0.

Parfyonator commented 1 year ago

Thank you!