axel-op / dart-package-analyzer

GitHub Action that uses the Dart Package Analyzer to compute the Pub score of Dart/Flutter packages
MIT License
52 stars 9 forks source link

Deprecating save-state and set-output commands #22

Closed Boehrsi closed 1 year ago

Boehrsi commented 1 year ago

It seems that GitHub updated some internal stuff and GitHub Actions must be updated until 31st May 2023, otherwise the action will fail with an error. More information: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I encounter the following messages during builds:

  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  total: 130
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  total_max: 130
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  conventions: 30
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  conventions_max: 30
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  documentation: 10
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  documentation_max: 10
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  platforms: 20
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  platforms_max: 20
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  analysis: 30
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  analysis_max: 30
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  dependencies: 20
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  dependencies_max: 20
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  null_safety: 20
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
  null_safety_max: 20
  Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I get the mentioned warnings during the Setting outputs part of the action. Thanks for the really helpful action by the way!

JaffaKetchup commented 1 year ago

Hey @axel-op, this deadline is getting quite close now! Any chance of this being updated?

axel-op commented 1 year ago

Hello,

Thank you for the issue. I've updated the GitHub Actions toolkit to use the environment files when setting an output. Please wait a few hours for the Docker image to be regenerated with this modification.

Also, sorry for the delay. I've been pretty busy these last weeks but I should now be able to respond in a more timely manner.

JaffaKetchup commented 1 year ago

Thanks @axel-op :) No worries about the wait.

JaffaKetchup commented 1 year ago

Hey @axel-op, sorry to bother you again ;| Not sure if this has worked fully, or if it's an issue with my implementation?

image

I use this code as well, but I don't think that it's an issue? image

Thanks for all your great work :)

axel-op commented 1 year ago

@JaffaKetchup My bad, I fixed the issue for environment variables but not for outputs! This should now be totally corrected :)

JaffaKetchup commented 1 year ago

Thanks @axel-op, certainly seems to be fixed!

Boehrsi commented 1 year ago

I can also confirm it's working now, thanks @axel-op