search

axel-op / dart-package-analyzer

GitHub Action that uses the Dart Package Analyzer to compute the Pub score of Dart/Flutter packages
MIT License
52 stars 9 forks source link

Multiple branch support #3

Closed shamblett closed 4 years ago

shamblett commented 4 years ago

I have the action in my master branch, this works OK if I trigger it from github.

I've added a branches: clause to the action to only run on three branches when pushed but this doesn't seem to be working, when I push one of my branches the action is not trigerred, and if it was would it run on the branch I have pushed or master?

I'm not clear on how to set this up.

axel-op commented 4 years ago

I'm not entirely sure I understand what's the issue here.

Everything is explained here, you have to edit your workflow file if you want it to be triggered on specific branches. You can use a pattern or you can directly specify the name of the branches you want your jobs to be triggered on.

Examples from the page I linked:

on:
  push:
    # Sequence of patterns matched against refs/heads
    branches:    
      - master         # Push events on master branch
      - 'mona/octocat' # Push events to branches matching refs/heads/mona/octocat
      - 'releases/**'  # Push events to branches matching refs/heads/releases/10

If you're talking about your repository mqtt_client I don't see any problem with your workflow, it will only run on the branches you specified.

Could you detail your issue a bit more?

shamblett commented 4 years ago

Yes, thanks for the reply, if you select the webclient branch on mqtt_client you can see that the latest commit was 

Latest commit ad3cc24 4 hours ago

Ok, I have this branch in the action, but I can't see where the output from the action is or if its been triggered, I does't seem to have run but this is a little new to me so I'm not sure if ist set up correctly.

axel-op commented 4 years ago

Oh, I see, this is related to the question in your first post that I didn't answer: the workflow is triggered on the branch in which you've pushed the commit. So here it isn't started because the workflow file isn't in your webclient branch. Maybe you should rebase this branch onto your master branch so there will be the file in both branches.

shamblett commented 4 years ago

Done this works fine now, great addition to my Dart workflow BTW.