values-zh-rCN/strings.xml

[1457384613gh]

values-zh-rCN/strings.xml

[axel358]

@1457384613gh You can grab/build one from the Github Actions tab

[utzcoz]

@axel358 @ilhan-athn7 @electrikjesus Could I add here an emoji of programmer? It will be so cute!

I think one of the rule of translating strings for different language is to keep the same and polish it with native language. If you want to add this icon/emoji, you need to add it to the origin content.

[electrikjesus]

I would agree with Utzcoz, it's not recommended to add differences in string translations unless it is a dialect or change in meaning (avoiding slang, etc). If you are proposing to add an emoji to the contributor string, then you will need to do it for all languages in order to be considered for review.

[axel358]

@1457384613gh U might need to use another device like your phone for testing or completly remove Smart Dock previous version before installing

[axel358]

@1457384613gh I might have forgotten to extract those strings. I'll do it as soon as i can

[axel358]

@1457384613gh Those strings are unused

[axel358]

@1457384613gh Ill do some cleanup when i have thr time, just ignore them

[utzcoz]

@1457384613gh Looks like you modified XML files have incorrect format content.

[utzcoz]

@1457384613gh It's recommended to let your PR as small as possible. Actually your later changes make your PR become more difficult to review, and it reduces the possibility of merging your PR.

[1457384613gh]

@axel358 @electrikjesus Do you agree to it？

It is that Edit the translation file in the order of the App's framework.

Its advantage is that

• The entropy is low.
• It is very convenient to translate.
• Avoid translations failing to correspond to real functions

How to check

Intall this apk to check. app-release_sign.zip

[axel358]

@1457384613gh Please keep the structure of the original strings.xml as it is. I agree that grouping strings is a good idea but is making it harder for us to review and merge your PR. Please remove all the emojis. Just limit yourself to translating the original english strings withput adding any extras. Over the course of next week i'll ask @utzcoz to review this PR one last time. If there are still issues we'll have to close it

[axel358]

@1457384613gh In the future i might implement your idea of grouping strings.

[1457384613gh]

The origin is hard for us to translate. I have already achieved it with entropy low. I can delete all emoji into English strings for you, but I don't want to delete all into zh strings. It is beacause it is convenient to read with emoji and emoji can break the sentence to make it more understandable.

I always think "to check" is easier than "to edit" for you; And "to edit" is harder than "to check" for you.

If easy, you could have done it before.

[axel358]

@1457384613gh I extacted the missing strings and removed unused ones, thanks for pointing those out. About the emojis, Smart Dock is used by many different. What you might find cool others might find rude. That's why we gotta try to keep the language as polite and neutral as possible, so that everyone is happy :)

[1457384613gh]

How about to add a function to select a language?

• English
• English with emoji
• Other
• Other with emoji

[1457384613gh]

value/strings.xml is without any emoji, now. Emoji is only into value-en-rHK and value-zh-rCH. Worldwide English is without emoji; Hong Kong English is with emoji. @axel358 @utzcoz

[1457384613gh]

Line 255, Use a custtom status bar height when calculating maximized window size Line 257, Icons to hide from the status bar Line 258,Blacklisted icons Line 259, null Give their string name-s there. @axel358