axelarnetwork / axelar-amplifier

Permissionless Connections Service run on the Axelar Network
21 stars 24 forks source link

feat(minor-voting-verifier): consistent gas cost for voting #476

Closed cjcobb23 closed 4 months ago

cjcobb23 commented 4 months ago

https://axelarnetwork.atlassian.net/browse/AXE-4318

Prior to this, the gas cost of each vote was more than prior votes in the same poll. Performance testing with 25 verifiers showed later votes costing over 100% more gas than earlier votes, which was causing out of gas errors. This PR makes the gas cost of each vote constant, except for the vote that achieves quorum. In testing with 25 verifiers and 20 messages in a batch, the vote that achieves quorum cost 6% more gas than other votes.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.40%. Comparing base (a64c6e0) to head (de12e73).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #476 +/- ## ========================================== + Coverage 93.39% 93.40% +0.01% ========================================== Files 177 177 Lines 23813 23863 +50 ========================================== + Hits 22240 22290 +50 Misses 1573 1573 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.