search

axelarnetwork / axelar-amplifier

Permissionless Connections Service run on the Axelar Network
21 stars 24 forks source link

ci(ampd): build ampd in gh actions #533

Closed milapsheth closed 3 months ago

milapsheth commented 3 months ago

Description

AXE-4509

Todos

Steps to Test

Expected Behaviour

Other Notes

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.07%. Comparing base (7e27cb7) to head (1be7b0e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #533 +/- ## ======================================= Coverage 94.07% 94.07% ======================================= Files 185 185 Lines 25904 25904 ======================================= Hits 24368 24368 Misses 1536 1536 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

milapsheth commented 3 months ago

what's the point of this? it's getting built for testing anyway. Or is it to specifically check the release build?

Yeah, the test build doesn't cover everything (it doesn't try building the actual binary/main entrypoint). We've had issues before where ampd build failed on main but the gh actions didn't fail on the PR