search

axelarnetwork / axelar-amplifier

Permissionless Connections Service run on the Axelar Network
21 stars 24 forks source link

feat(service-registry-api): add service-registry-api package #610

Closed maancham closed 1 month ago

maancham commented 1 month ago

Description

AXE-4789

Todos

Steps to Test

Expected Behaviour

Other Notes

cjcobb23 commented 1 month ago

why do we need this?

cgorenflo commented 1 month ago

why do we need this?

to break the cyclic dependency between service-registry and coordinator

cjcobb23 commented 1 month ago

why do we need this?

to break the cyclic dependency between service-registry and coordinator

For what exactly? Is there a planned change that will create a cyclic dependency?

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 99.09910% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.63%. Comparing base (2b2aa47) to head (ed9d4fa). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/service-registry-api/src/msg.rs 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #610 +/- ## ======================================= Coverage 93.63% 93.63% ======================================= Files 238 240 +2 Lines 33860 33870 +10 ======================================= + Hits 31704 31714 +10 Misses 2156 2156 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.