axelarnetwork / axelar-amplifier

Permissionless Connections Service run on the Axelar Network
21 stars 24 forks source link

fix(minor-coordinator)!: use String instead of Addr in messages #621

Closed cjcobb23 closed 1 month ago

cjcobb23 commented 1 month ago

Addr should not be used in the public facing API, because then the addresses bypass any sort of validation. Switched to string.

https://axelarnetwork.atlassian.net/browse/AXE-4842

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 98.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.59%. Comparing base (4d1fc52) to head (25ba013). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
contracts/coordinator/src/client.rs 90.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #621 +/- ## ========================================== - Coverage 93.60% 93.59% -0.02% ========================================== Files 237 236 -1 Lines 33771 33676 -95 ========================================== - Hits 31612 31518 -94 + Misses 2159 2158 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.