axelarnetwork / axelar-amplifier

Permissionless Connections Service run on the Axelar Network
21 stars 24 forks source link

chore(ampd): add openssl dependency as a vendored dependency to enable arm compilation #630

Closed apolikamixitos closed 1 month ago

apolikamixitos commented 1 month ago

Description

Explanation:

openssl library usage requires openssl being installed on the compilation machine that matches the target (in this case aarch64). This will cause issues to other users who want to compile amplifier for other targets architectures from a single machine (needs to reinstall and compile openssl for each target separately on their machines).

Todos

Steps to Test

Expected Behaviour

Other Notes

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.54%. Comparing base (1983493) to head (f87d5c9). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #630 +/- ## ======================================= Coverage 93.54% 93.54% ======================================= Files 241 241 Lines 33883 33883 ======================================= Hits 31697 31697 Misses 2186 2186 ``` | [Flag](https://app.codecov.io/gh/axelarnetwork/axelar-amplifier/pull/630/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axelarnetwork) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/axelarnetwork/axelar-amplifier/pull/630/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axelarnetwork) | `93.54% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axelarnetwork#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.